Merged
Conversation
- drop fingerprint, it can be derived from the certs
zachmargolis
requested review from
achapm,
jmhooper,
mitchellhenke,
orenyk and
stevegsa
orenyk
approved these changes
Apr 9, 2021
orenyk
left a comment
orenyk
left a comment
There was a problem hiding this comment.
LOVE it!
One thing I noticed though is that we don't have a unit test for an ServiceProvider.valid_signature? with multiple certs - I know it seems like a pain to write but it feels like it would be worthwhile given how complicated this is.
Otherwise, 
!
stevegsa
approved these changes
Apr 9, 2021
mitchellhenke
approved these changes
Apr 9, 2021
Author
Test coverage in this gem is really lacking and for the time being I think we can safely say that the tests in our own IDP cover this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to move some of the multi-cert logic inside the gem so that the IDP is simpler, see 18F/identity-idp#4898